Repository navigation
Show other homes' face-room lines as bubbles at once, never in the composer queue - #466
Merged
Birfy merged 3 commits intoOct 20, 2026
Merged
Conversation
Collaborator
Author
|
Self-review: PASS
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #455
What / why. In a face-to-face room, another person's line (
postHuman) or another home's approved Bot reply (postRemote) that arrived while this home's group Session was mid-turn wasfollowuped, so DSH parked it in the composer queue: raw[Group post from …]text, steerable with Cmd/Ctrl+Enter, and only drawn as a bubble after the turn. The receiving side also joined a person's typed line breaks (Markdown soft breaks).groups.jspostToRoom: a post from elsewhere (human/remote) while the room agent isrunningis held instead of queued. The running round (rt.roomProgress) shows it at once as that person's bubble (personReply) or the friend's Bot bubble (kind: 'remote', kept out of round reports); a Bot line is logged then, so the Bots still to speak see it (a person's line is already logged byapplyFaceLine). Afteragent.whenIdle()it isfollowuped withshown: true, so its own round routes it by the existing rules (who answers is unchanged), whilegroup_relayneither draws nor logs it a second time. With no round running it is only held and then goes exactly as before.turns.js: carriesshownonto the queued room item.cells.js: a trigger withshown: truedraws nothing (no duplicate bubble).styles.js:.bt-person-msg .bt-bubble :is(p,li){white-space:pre-line}, so a person's line keeps its line breaks, matching the sender's ownpre-wrapbubble.455-face-room-other-home-lines.fixed.md.Test.
core/test/rounds.test.js#455: while the round runs, a 3-line peer line and another home's Bot line land in the running round's replies at once (line breaks intact, no header), nothing is queued in the Session, the Bot line is logged once; after idle both are delivered withshown: true, and the next relay neither redraws nor re-logs them. Fails on main (the lines sit in the queue).core/test/face-people.test.js#455: ashowntrigger draws nothing (an unshown one does); the pre-line rule is inCONVERSATION_CSSand the bundle.ARCH_DOCS_BASE=origin/main TZ=UTC npm run verify: pass (core 1022, social 282, tree 80, timeline 80, scripts 88, interop 37, live-e2e 16; 0 failures).Risk tier: T2 (estimate, matches the risk-gate report; the controller sets the label)